Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐡 Better error message when package fails to load #2925

Merged
merged 2 commits into from
May 23, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented May 23, 2024

Changes:

  • stderr content from the precompilation process is captured and displayed in the Pkg log. It used to only show in the terminal that launched Pluto.
  • A new error rewriter in the frontend that detects the standard error message and replaces it with something more useful, also displaying a copy of the Pkg terminal with the error mesage for that package. This also hides the advice to Pkg.add the package which is wrong and would lead to problems.
  • The "precompile" status entry now shows in red if the precomp process failed

Before

image

After

image

@fonsp fonsp added documentation frontend Concerning the HTML editor backend Concerning the julia server and runtime labels May 23, 2024
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="better-package-load-error")
julia> using Pluto

@fonsp fonsp merged commit 2e272c5 into main May 23, 2024
12 of 13 checks passed
@fonsp fonsp deleted the better-package-load-error branch May 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime documentation frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant