Support mixed use of _ and - in launch parameter HTML attributes
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="fix-launch-params-attribute-underscore")
julia> using Pluto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of PlutoPages.jl has a bug where the slider_server_url setting is ignored. See JuliaPluto/PlutoPages.jl#1
This is because of this commit:
JuliaPluto/PlutoPages.jl@0890803
where the attributes are now passed to HypertextLiteral as a named tuple. The problem is that HypertextLiteral converts
_to-in attribute names (probably because this is better). You can see it in the HTML:This PR adds a patch to Pluto to also read attributes that use
-in the name instead of_.This will fix JuliaPluto/PlutoPages.jl#1