Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX (CodeAnalyzer): @W-15253475@: Exporting types so it can be used outside of the cli #1412

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

jag-j
Copy link
Collaborator

@jag-j jag-j commented Mar 22, 2024

No description provided.

@jag-j jag-j changed the title FIX @W-15253475@ Exporting types so it can be used outside of the cli FIX (Scanner) @W-15253475@ Exporting types so it can be used outside of the cli Mar 22, 2024
@jag-j jag-j changed the title FIX (Scanner) @W-15253475@ Exporting types so it can be used outside of the cli FIX (CodeAnalyzer) @W-15253475@ Exporting types so it can be used outside of the cli Mar 22, 2024
@jag-j jag-j changed the title FIX (CodeAnalyzer) @W-15253475@ Exporting types so it can be used outside of the cli FIX (CodeAnalyzer): @W-15253475@ Exporting types so it can be used outside of the cli Mar 22, 2024
@jag-j jag-j changed the title FIX (CodeAnalyzer): @W-15253475@ Exporting types so it can be used outside of the cli FIX (CodeAnalyzer): @W-15253475@: Exporting types so it can be used outside of the cli Mar 22, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this file need to be renamed? My understanding is that types is one of the files that usually should be a .d.ts.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my thoughts as well until I saw the video posted by Stephen here #1413 (comment)

@jag-j jag-j merged commit ac5751f into dev Mar 25, 2024
11 checks passed
@jag-j jag-j deleted the jj/W-15253475 branch March 25, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants