This repository was archived by the owner on Aug 10, 2021. It is now read-only.
remove go.mod, as the version is incompatible #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit bc6d185, which is a security fix, also added a go.mod to this repository. However, the current name of this project does not include a versioned import-path, which makes the module not usable when using a tag. (go modules allows invalid versions (`+incompatible`) if the repository does not have a go.mod, but will refuse to use the module otherwise. This patch removes the go.mod Signed-off-by: Sebastiaan van Stijn <[email protected]>
alex-pricope-form3
approved these changes
Aug 9, 2021
|
Thanks for the detailed report - we will merge this. |
Thanks! I was planning to open a ticket around that to propose doing so (unifying the forks); golang-jwt/jwt#40 (comment), but didn't come round to it yet 👍 |
2 tasks
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit bc6d185, which is a security
fix, also added a go.mod to this repository. However, the current
name of this project does not include a versioned import-path,
which makes the module not usable when using a tag. (go modules
allows invalid versions (
+incompatible) if the repository doesnot have a go.mod, but will refuse to use the module otherwise.
This patch removes the go.mod
relates to #14, distribution/distribution#3459 (comment)
It possible, a new tag should be made with this fix, to prevent users from being able to use the security fix