fix: Add order component for organizers #5291

divyamtayal · 2020-10-11T21:21:34Z

Fixes #5184

Short description of what this resolves:

Event created by the user was not able to add Order manually, so this issue is resolved.

Changes proposed in this pull request:

Since ticket-list component is being used for events for buying tickets, and it has proper functionality, use of ticket-list component is used for add Order manually
placeOrder save function defined in controllers/events/view/tickets/add-order.js is changed according to need of ticket-list component

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Before

Changes made

After selecting tickets

Test Screenshot

vercel · 2020-10-11T21:21:40Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/k8linwyoi
✅ Preview: https://open-event-frontend-git-development.eventyay.now.sh

codecov · 2020-10-11T21:34:35Z

Codecov Report

Merging #5291 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #5291      +/-   ##
===============================================
- Coverage        22.78%   22.78%   -0.01%     
===============================================
  Files              491      491              
  Lines             5245     5232      -13     
  Branches            37       37              
===============================================
- Hits              1195     1192       -3     
+ Misses            4045     4035      -10     
  Partials             5        5

Impacted Files	Coverage Δ
app/components/public/ticket-list.js	`18.96% <0.00%> (-1.22%)`	⬇️
app/controllers/events/view/tickets/add-order.js	`0.00% <0.00%> (ø)`
app/components/tabbed-navigation.js	`33.33% <0.00%> (-20.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4b399...46b1be3. Read the comment docs.

iamareebjamal · 2020-10-12T02:00:20Z

Now, you need to make price editable for just admins. To make it simpler, just make the final price editable

divyamtayal · 2020-10-12T07:19:41Z

Now, you need to make price editable for just admins. To make it simpler, just make the final price editable

ok, and is everything else is fine or do I have to make some changes in that also?

iamareebjamal · 2020-10-12T09:36:23Z

It looks fine to me

divyamtayal · 2020-10-13T07:35:31Z

Now, you need to make price editable for just admins. To make it simpler, just make the final price editable

by the user who created the event?

iamareebjamal · 2020-10-13T08:42:19Z

Yes

divyamtayal · 2020-10-13T22:14:39Z

could you please help me out how to add or pass data from one route to other route bcz for changing total price manually I have to change it in /events/:event_id/tickets.add-order and change it in /orders/:order_id/new bcz after clicking order now the website is redirected to /order/:order_id/new route.

Everything is done, final price is editable, just left with working of it.

iamareebjamal · 2020-10-14T05:45:37Z

Just make it possible that amount is sent in the API request and add a GIF of editing the price. Rest I will do

divyamtayal · 2020-10-16T15:08:57Z

Is this the correct way of sending update order request? (for eg. if we have to set amount=0)
bcz this is what I get after reading documentation of api server.

After doing like this I am getting this error on my console, so I suppose this is the error which is to done from server side and I think this is what you were talking about.
Please let me know.

It is working on Postman when req PATCH req on for eg.
URL - https://open-event-api-dev.herokuapp.com/v1/orders/889
body -

{
  "data": {
    "attributes": {
        "amount": 0
    },
    "type": "order",
    "id": "889"
  }
}

iamareebjamal · 2020-10-16T17:20:39Z

As I said, you just have to create the UI. Update will be handled in the server by me. Just ensure the local amount can be edited in the UI

divyamtayal · 2020-10-16T19:15:57Z

Order total is now editable only for user's who created particular event.
And I removed the promotional code from here but its still there for others who are buying the tickets.
Because I think if we are able to edit the total, then there is no point of keeping of promotional code.

Price is edited

Now on clicking on Order Now, order is created for actual price and not for edited price so I think I have to make that functional.

This for others users buying tickets same as before

Please let me know to make nay changes for this part.

app/templates/components/public/ticket-list.hbs

divyamtayal · 2020-10-22T12:59:08Z

@iamareebjamal Please review this issue and let me know if I have to make any changes.

iamareebjamal · 2020-10-22T13:09:05Z

Yes, will do it today. Have some more important things to do. You can take up other issues till then

divyamtayal · 2020-10-22T13:17:45Z

Yes, will do it today. Have some more important things to do. You can take up other issues till then

Ok Thank you. I have one doubt regarding the issues that we have solved.
Do we have to submit scrum report or something like gists?

iamareebjamal · 2020-10-22T15:37:09Z

No

divyamtayal · 2020-10-24T23:15:46Z

Yes, will do it today. Have some more important things to do. You can take up other issues till then

@iamareebjamal Please review this issue so that I can work on other issue and start commiting.

iamareebjamal · 2020-10-25T01:15:41Z

Why does the review of this PR stops you from working on other issues?

divyamtayal · 2020-10-25T03:18:42Z

Why does the review of this PR stops you from working on other issues?

Then how will I able to commit the changes in other issue. bcz this changes are yet merged in.
Do I have to make new branch and work in that?

iamareebjamal · 2020-10-25T09:51:09Z

Of course. That's how you work. There are 5 PRs created by me that have not been merged for months. I still work daily. That's why branches exist. You should never create a PR or commit on development branch.

divyamtayal · 2020-10-25T15:45:12Z

Of course. That's how you work. There are 5 PRs created by me that have not been merged for months. I still work daily. That's why branches exist. You should never create a PR or commit on development branch.

So as for this issue I have commit on development branch which I think I have done wrong so should I have to do anything regarding this to improve it and from now on new issues I should create new branch and then work accordingly? And should I close this PR and make new one for the same issue from new branch making same changes?

An also acc to what your are saying, we can work on multiple issues at same time?

iamareebjamal · 2020-10-25T16:22:32Z

new issues I should create new branch and then work accordingly?

Yes

And should I close this PR and make new one for the same issue from new branch making same changes?

No, just create a new branch. Run git reset --hard upstream/development on it and start working on new issues

An also acc to what your are saying, we can work on multiple issues at same time?

No, you work on 1 issue at a time. Since your work on this issue is complete, you move to next issue

iamareebjamal · 2020-10-25T18:08:42Z

The input was not working to change the amount and sending it to the server. I have fixed the working of the component 46b1be3 (#5291)

vercel bot deployed to Preview October 11, 2020 21:21 View deployment

iamareebjamal mentioned this pull request Oct 13, 2020

feat: Event screen and Side Drawer open-roboclub/roboclub-flutter#6

Merged

vercel bot deployed to Preview October 13, 2020 16:39 View deployment

vercel bot deployed to Preview October 16, 2020 19:03 View deployment

vercel bot deployed to Preview October 16, 2020 19:24 View deployment

iamareebjamal self-requested a review October 19, 2020 06:40

iamareebjamal reviewed Oct 19, 2020

View reviewed changes

app/templates/components/public/ticket-list.hbs Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 20, 2020 15:47 View deployment

vercel bot deployed to Preview October 20, 2020 15:51 View deployment

daretobedifferent18 and others added 6 commits October 25, 2020 22:08

Fixed Add Order Manually

478515e

Fixed Add Order manually

f0e1f0b

Order amount Edited

06b8148

Order amount Edited

ea490fd

changes prop name

40bd2a7

fix

46b1be3

vercel bot deployed to Preview October 25, 2020 18:07 View deployment

iamareebjamal changed the title ~~Fixed Add Order manually~~ fix: Add order component for organizers Oct 25, 2020

auto-label bot added the fix label Oct 25, 2020

iamareebjamal merged commit e639adb into fossasia:development Oct 25, 2020

iamareebjamal mentioned this pull request Oct 25, 2020

chore: Remove ember-models-table #5379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add order component for organizers #5291

fix: Add order component for organizers #5291

divyamtayal commented Oct 11, 2020 •

edited

Loading

vercel bot commented Oct 11, 2020 •

edited

Loading

codecov bot commented Oct 11, 2020 •

edited

Loading

iamareebjamal commented Oct 12, 2020 •

edited

Loading

divyamtayal commented Oct 12, 2020

iamareebjamal commented Oct 12, 2020

divyamtayal commented Oct 13, 2020 •

edited

Loading

iamareebjamal commented Oct 13, 2020

divyamtayal commented Oct 13, 2020 •

edited

Loading

iamareebjamal commented Oct 14, 2020

divyamtayal commented Oct 16, 2020 •

edited

Loading

iamareebjamal commented Oct 16, 2020

divyamtayal commented Oct 16, 2020 •

edited

Loading

divyamtayal commented Oct 22, 2020

iamareebjamal commented Oct 22, 2020

divyamtayal commented Oct 22, 2020

iamareebjamal commented Oct 22, 2020

divyamtayal commented Oct 24, 2020 •

edited

Loading

iamareebjamal commented Oct 25, 2020

divyamtayal commented Oct 25, 2020

iamareebjamal commented Oct 25, 2020

divyamtayal commented Oct 25, 2020 •

edited

Loading

iamareebjamal commented Oct 25, 2020

iamareebjamal commented Oct 25, 2020

fix: Add order component for organizers #5291

fix: Add order component for organizers #5291

Conversation

divyamtayal commented Oct 11, 2020 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

vercel bot commented Oct 11, 2020 • edited Loading

codecov bot commented Oct 11, 2020 • edited Loading

Codecov Report

iamareebjamal commented Oct 12, 2020 • edited Loading

divyamtayal commented Oct 12, 2020

iamareebjamal commented Oct 12, 2020

divyamtayal commented Oct 13, 2020 • edited Loading

iamareebjamal commented Oct 13, 2020

divyamtayal commented Oct 13, 2020 • edited Loading

iamareebjamal commented Oct 14, 2020

divyamtayal commented Oct 16, 2020 • edited Loading

iamareebjamal commented Oct 16, 2020

divyamtayal commented Oct 16, 2020 • edited Loading

divyamtayal commented Oct 22, 2020

iamareebjamal commented Oct 22, 2020

divyamtayal commented Oct 22, 2020

iamareebjamal commented Oct 22, 2020

divyamtayal commented Oct 24, 2020 • edited Loading

iamareebjamal commented Oct 25, 2020

divyamtayal commented Oct 25, 2020

iamareebjamal commented Oct 25, 2020

divyamtayal commented Oct 25, 2020 • edited Loading

iamareebjamal commented Oct 25, 2020

iamareebjamal commented Oct 25, 2020

divyamtayal commented Oct 11, 2020 •

edited

Loading

vercel bot commented Oct 11, 2020 •

edited

Loading

codecov bot commented Oct 11, 2020 •

edited

Loading

iamareebjamal commented Oct 12, 2020 •

edited

Loading

divyamtayal commented Oct 13, 2020 •

edited

Loading

divyamtayal commented Oct 13, 2020 •

edited

Loading

divyamtayal commented Oct 16, 2020 •

edited

Loading

divyamtayal commented Oct 16, 2020 •

edited

Loading

divyamtayal commented Oct 24, 2020 •

edited

Loading

divyamtayal commented Oct 25, 2020 •

edited

Loading