Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add icon and option for Weblate in footer #5656

Merged
merged 5 commits into from
Nov 20, 2020
Merged

feat: Add icon and option for Weblate in footer #5656

merged 5 commits into from
Nov 20, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 16, 2020 •
edited
Loading

Fixes #5635

Short description of what this resolves:

require fossasia/open-event-server#7451

add another option to add a link to Weblate to the Footer.
it is configurable just like the other options in this footer area.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

k1

@auto-label auto-label bot added the feature label Nov 16, 2020
@vercel
Copy link

vercel bot commented Nov 16, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7lbvf5sks
✅ Preview: https://open-event-frontend-git-add-weblate.eventyay.now.sh

@sachinchauhan2889 sachinchauhan2889 mentioned this pull request Nov 16, 2020
Closed
6 tasks
@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #5656 (0ea40c2) into development (5d34f21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5656   +/-   ##
============================================
  Coverage        23.72%   23.72%           
============================================
  Files              498      498           
  Lines             5277     5277           
  Branches            47       47           
============================================
  Hits              1252     1252           
  Misses            4017     4017           
  Partials             8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...b94b3e1. Read the comment docs.

@sachinchauhan2889 sachinchauhan2889 mentioned this pull request Nov 16, 2020
Merged
6 tasks
@sachinchauhan2889 sachinchauhan2889 changed the title feature: Footer "Connect with us": Add icon and option for Weblate feat: Add icon and option for Weblate in footer Nov 16, 2020
@iamareebjamal
Copy link
Member

Please use monochrome svg icon

@sachinchauhan2889
Copy link
Contributor Author

Please use monochrome svg icon

@iamareebjamal sir, not able to find weblate monochrome svg icon. I think it is very rare icon. I tried on many sites but not get icon. Thats why i used this.

@iamareebjamal
Copy link
Member

Have you tried, ..., wait for it, ..., drumrolls, ...... https://hosted.weblate.org/?

@sachinchauhan2889
Copy link
Contributor Author

wbsa

iamareebjamal
iamareebjamal reviewed Nov 18, 2020
View reviewed changes
app/templates/components/footer-main.hbs Outdated
@@ -93,6 +93,11 @@
<i class="telegram icon"></i> {{t 'Telegram'}}
</a>
{{/if}}
{{#if this.socialLinks.weblateUrl}}
<a class="item" href="{{this.socialLinks.weblateUrl}}" target="_blank" rel="noopener noreferrer">
<img src="{{if this.socialLinks.weblateUrl '/images/weblate icon.png'}}" class="weblate-icon"> {{t 'Weblate'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monochrome SVG icon

@iamareebjamal
Copy link
Member

Please use monochrome svg icon

svg

@sachinchauhan2889
Copy link
Contributor Author

https://semantic-ui.com/elements/icon.html
https://fontawesome.com/icons?d=gallery
https://fontawesome.com/icons?d=gallery&q=weblate

@iamareebjamal @mariobehling sir, there is no exact icon for weblate in font awesome and semantic ui icons.

@iamareebjamal
Copy link
Member

Have you tried, ..., wait for it, ..., drumrolls, ...... hosted.weblate.org?

@iamareebjamal iamareebjamal merged commit 52a5796 into fossasia:development Nov 20, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the add-weblate branch November 20, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footer "Connect with us": Add icon and option for Weblate
2 participants
@sachinchauhan2889 @iamareebjamal