fix: check for case where client sends null for max_quantity

fossasia · Aug 10, 2019 · 91d93e1 · 91d93e1
1 parent c1148bd
commit 91d93e1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/api/schema/discount_codes.py b/app/api/schema/discount_codes.py
@@ -86,7 +86,7 @@ def validate_quantity(self, data, original_data):
 
         DiscountCodeSchemaEvent.quantity_validation_helper(data)
 
-        if 'tickets_number' in data and 'max_quantity' in data:
+        if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None:
             if data['tickets_number'] < data['max_quantity']:
                 raise UnprocessableEntity({'pointer': '/data/attributes/tickets-number'},
                                           "tickets-number should be greater than max-quantity")
@@ -149,7 +149,7 @@ def validate_quantity(self, data, original_data):
 
         DiscountCodeSchemaTicket.quantity_validation_helper(data)
 
-        if 'tickets_number' in data and 'max_quantity' in data:
+        if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None:
             if data['tickets_number'] < data['max_quantity']:
                 raise UnprocessableEntity({'pointer': '/data/attributes/tickets-number'},
                                           "tickets-number should be greater than max-quantity")