fix: Allow admin/organizer to edit/add sessions without speaker call (#…

…7440) even when speaker call is not present
fossasia · Nov 12, 2020 · b071ea3 · b071ea3
1 parent bf35477
commit b071ea3
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/app/api/helpers/speaker.py b/app/api/helpers/speaker.py
@@ -13,17 +13,20 @@ def can_edit_after_cfs_ends(event_id):
     speakers_call = SpeakersCall.query.filter_by(
         event_id=event_id, deleted_at=None
     ).one_or_none()
+    not_allowed = not (
+        has_access('is_admin')
+        or has_access('is_organizer', event_id=event_id)
+        or has_access('is_coorganizer', event_id=event_id)
+    )
     if speakers_call:
         speakers_call_tz = speakers_call.ends_at.tzinfo
         return not (
             speakers_call.ends_at <= datetime.now().replace(tzinfo=speakers_call_tz)
-            and not (
-                has_access('is_admin')
-                or has_access('is_organizer', event_id=event_id)
-                or has_access('is_coorganizer', event_id=event_id)
-            )
+            and not_allowed
         )
-    raise ForbiddenError(
-        {'source': '/data/event-id'},
-        f'Speaker Calls for event {event_id} not found',
-    )
+    elif not_allowed:
+        raise ForbiddenError(
+            {'source': '/data/event-id'},
+            f'Speaker Calls for event {event_id} not found',
+        )
+    return True