Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FallBack to SMTP when SendGrid Fails/Exceeds Quota #5958

Closed
mrsaicharan1 opened this issue May 26, 2019 · 3 comments · Fixed by #5981
Closed

FallBack to SMTP when SendGrid Fails/Exceeds Quota #5958

mrsaicharan1 opened this issue May 26, 2019 · 3 comments · Fixed by #5981

Comments

@mrsaicharan1
Copy link
Member

Describe the feature request
We need a feature in the system where the SMTP protocol must be used when SendGrid's quota exceeds/ fails to work.
This is essential as whenever someone orders a ticket, they expect the tickets/invoice to reach them via mail. A backup service like this would be useful.

Additional context
Working on it.

@iamareebjamal
Copy link
Member

A simpler version should be implemented first. An email sender object that provides an interface like send_email so that we can just use it. And internally it checks the configuration and uses sendgrid or SMTP according to config present. Then it can be enhanced to add the fallback usage

@mrsaicharan1
Copy link
Member Author

Oh, okay ! @iamareebjamal , just to clarify, we have two separate tasks written out, send_email_task for Sendgrid and send_mail_via_smtp_task for SMTP. Do you mean that we just need one method which checks for the internal config and sends it according to the enabled protocol?

@iamareebjamal
Copy link
Member

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants