-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SMTP as a fallback function when Sendgrid quota exceeds limit #5981
feat: SMTP as a fallback function when Sendgrid quota exceeds limit #5981
Conversation
28431d6
to
649779a
Compare
Codecov Report
@@ Coverage Diff @@
## development #5981 +/- ##
=============================================
Coverage ? 66.1%
=============================================
Files ? 285
Lines ? 14122
Branches ? 0
=============================================
Hits ? 9335
Misses ? 4787
Partials ? 0
Continue to review full report at Codecov.
|
67e81ab
to
e9747f3
Compare
1300c5b
to
ae8c550
Compare
ae8c550
to
24db6ef
Compare
Tests are failing because your code is trying to send emails and failing:
|
Found the freaking culprit: https://api.eventyay.com/#settings-settings-details-patch Not only it sets the sendgrid key to a random value, it also changes the environment to production!!! Fix the docs and the error will be gone. Just change the app-environment to testing |
Something else is changing the app config. Need to debug more |
@iamareebjamal This is only due to the random app config change right? Because I made sure that the email is not being sent when neither of them are configured. |
Yes, it is due to config changes |
@iamareebjamal Looks good I guess. Travis seems to go through now :) |
72f4e00
to
2a69f30
Compare
2a69f30
to
99253ab
Compare
99253ab
to
91af8cb
Compare
@iamareebjamal Please have a look now. |
91af8cb
to
559ebcd
Compare
Modified arguments placement Corrected quota info Sent email and handled error Cease email service if SMTP not configured fix travis divided into two tasks changed logger message and smtp fallback
559ebcd
to
6d9f6d2
Compare
…ossasia#5981) Modified arguments placement Corrected quota info Sent email and handled error Cease email service if SMTP not configured fix travis divided into two tasks changed logger message and smtp fallback
Fixes #5958
Checklist
development
branch.Short description of what this resolves:
Changes proposed in this pull request:
send_email_via_smtp