Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in link provided in new session proposal email #5976

Closed
ShridharGoel opened this issue May 30, 2019 · 2 comments · Fixed by #6010
Closed

Error in link provided in new session proposal email #5976

ShridharGoel opened this issue May 30, 2019 · 2 comments · Fixed by #6010
Labels
bug
Milestone
Milestone 3: Summ...

Comments

@ShridharGoel
Copy link
Member

Describe the bug
The link contains an extra / after https://fossasia.github.io/open-event-frontend/

New session proposal wrong link
@kushthedude kushthedude added the bug label Jun 5, 2019
@mariobehling mariobehling added this to the Milestone 3: Summer 2019 milestone Jun 5, 2019
@mrsaicharan1
Copy link
Member

@iamareebjamal What is the exact frontend url in production?

@mrsaicharan1 mrsaicharan1 mentioned this issue Jun 7, 2019
Merged
6 tasks
@iamareebjamal
Copy link
Member

Doesn't matter, make_frontend_url should handle it. I have written tests for it. Check why it happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Milestone 3: Summer 2019
Development

Successfully merging a pull request may close this issue.

fix: Fix session proposal email link mrsaicharan1/open-event-server
5 participants
@mariobehling @iamareebjamal @mrsaicharan1 @ShridharGoel @kushthedude