-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix session proposal email link #6010
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6010 +/- ##
==============================================
Coverage ? 66.26%
==============================================
Files ? 285
Lines ? 14005
Branches ? 0
==============================================
Hits ? 9280
Misses ? 4725
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrsaicharan1 are we going to update the frontend url in this PR too?
If not, this PR LGTM
Please use make_frontend_url. It handles all these edge cases |
Yes, will do that.
…On Sat, 8 Jun 2019 at 10:50 AM, Areeb Jamal ***@***.***> wrote:
Please use make_frontend_url. It handles all these edge cases
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6010?email_source=notifications&email_token=AGAHUW3OG4KA6VFTA6M7XWTPZPIL3A5CNFSM4HVZV5B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHXEOA#issuecomment-500134456>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGAHUW5HVYDTXGXKK32GZRTPZPIL3ANCNFSM4HVZV5BQ>
.
|
@uds5501 @shreyanshdwivedi Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Fixes #5976
Checklist
development
branch.Short description of what this resolves:
There is an extra leading slash present which gives a wrong url link to the new session proposal.
This fix removes the leading slash for it.
Changes proposed in this pull request: