Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix session proposal email link #6010

Merged
merged 2 commits into from
Jun 9, 2019

Conversation

mrsaicharan1
Copy link
Member

@mrsaicharan1 mrsaicharan1 commented Jun 7, 2019

Fixes #5976

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

There is an extra leading slash present which gives a wrong url link to the new session proposal.
This fix removes the leading slash for it.

Changes proposed in this pull request:

  • Fixes the buggy link for sessions proposal.

@auto-label auto-label bot added the fix label Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@386ecc6). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #6010   +/-   ##
==============================================
  Coverage               ?   66.26%           
==============================================
  Files                  ?      285           
  Lines                  ?    14005           
  Branches               ?        0           
==============================================
  Hits                   ?     9280           
  Misses                 ?     4725           
  Partials               ?        0
Impacted Files Coverage Δ
app/api/sessions.py 41.66% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386ecc6...15718a9. Read the comment docs.

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrsaicharan1 are we going to update the frontend url in this PR too?
If not, this PR LGTM

@iamareebjamal
Copy link
Member

Please use make_frontend_url. It handles all these edge cases

@mrsaicharan1
Copy link
Member Author

mrsaicharan1 commented Jun 8, 2019 via email

@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi Please review

Copy link
Member

@kushthedude kushthedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@niranjan94 niranjan94 merged commit a3a38d9 into fossasia:development Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in link provided in new session proposal email
5 participants