Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send mail only if SMTP was configured(Event Export) #6228

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

mrsaicharan1
Copy link
Member

Fixes #6158

Short description of what this resolves:

When sending an email fails, the event export fails with a message saying that the export failed, which is not expected.

Changes proposed in this pull request:

  • Checked SMTP config before calling export_mail
  • Logged appropriate warnings

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #6228 into development will decrease coverage by 0.02%.
The diff coverage is 12.5%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6228      +/-   ##
===============================================
- Coverage        65.71%   65.69%   -0.03%     
===============================================
  Files              286      286              
  Lines            14523    14529       +6     
===============================================
+ Hits              9544     9545       +1     
- Misses            4979     4984       +5
Impacted Files Coverage Δ
app/api/helpers/tasks.py 17.56% <12.5%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed4363...4196a01. Read the comment docs.

@mrsaicharan1 mrsaicharan1 force-pushed the smtp-event-fix branch 2 times, most recently from a4aadeb to 0c54cb4 Compare July 23, 2019 06:44
Correct usage of func

Add missing SMTP parameter
@mrsaicharan1
Copy link
Member Author

@iamareebjamal @shreyanshdwivedi @uds5501 Please review

@iamareebjamal iamareebjamal merged commit 7dd5282 into fossasia:development Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Export: Celery export tries to access SMTP Configs
5 participants