feat: Transaction Processing logic & Wallet linking implementation #6399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## development #6399 +/- ##
===============================================
- Coverage 64.9% 64.74% -0.16%
===============================================
Files 288 288
Lines 14912 14966 +54
===============================================
+ Hits 9678 9690 +12
- Misses 5234 5276 +42
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Aug 20, 2019
| response = requests.post(url, data=post_data, headers={"Content-type": "application/json"}) | ||
| return response.json() | ||
|
|
||
| @order_misc_routes.route('/orders/<string:order_identifier>/paytm/fetch-payment-options/<string:txn_token>') |
| else: | ||
| url = "https://securegw.paytm.in/theia/api/v1/" # for production | ||
| return url | ||
| @staticmethod |
houndci-bot
reviewed
Aug 20, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
from
b30f882 to
9ed5a0f
Compare
houndci-bot
reviewed
Aug 20, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
2 times, most recently
from
5b655c5 to
ebe9502
Compare
houndci-bot
reviewed
Aug 20, 2019
6 tasks
houndci-bot
reviewed
Aug 21, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
from
6adefb0 to
d6bc2a3
Compare
mrsaicharan1
changed the title
|
@shreyanshdwivedi @uds5501 This is now ready for a review. Let's speed this up so that we can link it with the frontend pipeline. |
mrsaicharan1
force-pushed
the
paytm-final
branch
2 times, most recently
from
dd3ba93 to
859da6b
Compare
houndci-bot
reviewed
Aug 21, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
from
859da6b to
a96d9b2
Compare
uds5501
reviewed
Aug 22, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
from
a96d9b2 to
f88923b
Compare
|
@shreyanshdwivedi @uds5501 I've made the requested changes. Please have a look now. |
uds5501
previously approved these changes
Aug 22, 2019
uds5501
reviewed
Aug 22, 2019
mrsaicharan1
force-pushed
the
paytm-final
branch
from
f88923b to
386db97
Compare
|
@uds5501 @shreyanshdwivedi I've made the requested changes. This is ready for another review. |
|
I've also added the JWT decorator to ensure proper routing based on authentication. |
uds5501
approved these changes
Aug 23, 2019
shreyanshdwivedi
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6247
Fixes #6353
Short description of what this resolves:
This PR aims to fetch the payment options available for a particular order, validate one-time passwords and process the transactions.
Changes proposed in this pull request: