fix: Removing currency symbol filter #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CosmicCoder96 @iamareebjamal Please Review |
Codecov Report
@@ Coverage Diff @@
## development #6429 +/- ##
============================================
Coverage 64.49% 64.49%
============================================
Files 291 291
Lines 15117 15117
============================================
Hits 9749 9749
Misses 5368 5368Continue to review full report at Codecov.
|
| @@ -123,7 +123,7 @@ <h3 style="text-align:center;">{{ holders[0].event.name }} - {{ ("Attendees List | |||
| {{ holder.email }}<br> | |||
| </strong> | |||
| {% if holder.ticket.price %} | |||
| {{ holder.event.payment_currency | currency_symbol }}{{ holder.ticket.price | money }} | |||
| {{ holder.event.payment_currency }}{{ holder.ticket.price | money }} | |||
There was a problem hiding this comment.
@kushthedude please add screenshot of the change for reference.
|
@kushthedude can you please update this? |
pr was already ready, added the ss |
iamareebjamal
approved these changes
Sep 2, 2019
shreyanshdwivedi
approved these changes
Sep 2, 2019
|
@uds5501 Merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6428
Short description of what this resolves:
Removes the currency symbol template filter which was not able to render most of the currency symbols due to a rendering issue with PISA