chore(docs): Remove broken docker deploy button #6561
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6561 +/- ##
============================================
Coverage 65.03% 65.03%
============================================
Files 296 296
Lines 15248 15248
============================================
Hits 9916 9916
Misses 5332 5332Continue to review full report at Codecov.
|
README.md
Outdated
| @@ -53,7 +53,7 @@ The Open Event Server can be easily deployed on a variety of platforms. Detailed | |||
|
|
|||
| One-click Heroku and Docker deployments are also available: | |||
|
|
|||
| [](https://cloud.docker.com/stack/deploy/?repo=https://github.com/fossasia/open-event-server) [](https://heroku.com/deploy) | |||
| [](https://cloud.docker.com/stack/deploy/?repo=https://github.com/fossasia/open-event-server) [](https://heroku.com/deploy) | |||
There was a problem hiding this comment.
Gives 404, so either this should be removed or fixed
There was a problem hiding this comment.
@iamareebjamal I am seeing the image on GitHub also in PR
There was a problem hiding this comment.
There was a problem hiding this comment.
https://cloud.docker.com/stack/deploy/?repo=https://github.com/fossasia/open-event-server
@iamareebjamal The link is the same as you have sent above for after the click
There was a problem hiding this comment.
And it gives 404, so it doesn't work
There was a problem hiding this comment.
@iamareebjamal I am not getting what you are telling sorry for that as the link "https://cloud.docker.com/stack/deploy/?repo=https://github.com/fossasia/open-event-server" opens hub.docker.com for me
There was a problem hiding this comment.
"And it gives 404, so it doesn't work."
Can you deploy to docker cloud through the link?
Does it show anything else than 404 Page not found?
If not, then the link doesn't work. There is no use of a button which doesn't work. Either it should be fixed so clicking on it deploys to docker cloud or removed
There was a problem hiding this comment.
@iamareebjamal I got it now what you are trying to say will remove it ASAP
|
@iamareebjamal I have removed the link and also changed the line of the explanation above it accordingly |
iamareebjamal
changed the title
Fixes #6556
Short description of what this resolves:
The image of docker in the Readme.md file is broken
Changes proposed in this pull request:
Checklist
developmentbranch.