New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made ticket_id and event_id not null in Ticket Holder #6674

Closed

Rits1272 wants to merge 1 commit into fossasia:development from Rits1272:dev

Member

Rits1272 commented Dec 17, 2019

fixes #6669 Made ticket_id and event_id not null in TicketHolder

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
The unit tests pass locally with my changes
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.


          Made ticket_id and event_id not null in Ticket Holder

afbfb5c

Member Author

Rits1272 commented Dec 17, 2019

Please review @iamareebjamal

Contributor

codedsun commented Dec 17, 2019 •

edited

Loading

@Rits1272 When someone else was working on the issue, how you can raise a PR?

We have some ethics and rules here, that need to be followed.

Member

kushthedude commented Dec 17, 2019

@codedsun mentioned correctly, Please read Contribution Guidelines.
Thanks

kushthedude closed this

Member Author

Rits1272 commented Dec 17, 2019

Sorry @kushthedude and @codedsun! I will not repeat the same mistake again.

Rits1272 deleted the dev branch

December 17, 2019 08:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet