Update ticket_holder table schema #6675

ashwani99 · 2019-12-17T10:31:32Z

Fixes #6669

Short description of what this resolves:

Updated the fields ticket_id and event_id to be not null

Changes proposed in this pull request:

Updated schema of ticket_holder table. The fields ticket_id and event_id have been added with not null contraint

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
The unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

codedsun · 2019-12-17T18:59:35Z

app/factories/attendee.py

@@ -11,6 +12,7 @@ class Meta:
        sqlalchemy_session = db.session

    event = factory.RelatedFactory(EventFactoryBasic)
+    ticket = factory.RelatedFactory(TicketFactory)


Without doing this, while running tests, some test were failing because of ticket_id being None

app/factories/attendee.py

codedsun

Please check for CI Failing.

vishakhanihore · 2019-12-17T19:35:25Z

Migration is needed for this.

codedsun

Your dredd test are failing, also do create the migration

codecov · 2019-12-19T07:42:29Z

Codecov Report

❗ No coverage uploaded for pull request base (development@537a263). Click here to learn what that means.
The diff coverage is 95.94%.

@@              Coverage Diff               @@
##             development    #6675   +/-   ##
==============================================
  Coverage               ?   65.61%           
==============================================
  Files                  ?      300           
  Lines                  ?    15256           
  Branches               ?        0           
==============================================
  Hits                   ?    10010           
  Misses                 ?     5246           
  Partials               ?        0

Impacted Files	Coverage Δ
app/views/blueprints.py	`58.2% <ø> (ø)`
app/models/event.py	`78.7% <ø> (ø)`
app/api/schema/events.py	`91.33% <ø> (ø)`
app/api/routes.py	`100% <ø> (ø)`
app/api/schema/attendees.py	`98.21% <ø> (ø)`
app/api/attendees.py	`40% <ø> (ø)`
tests/all/integration/test_migrations.py	`100% <100%> (ø)`
tests/all/integration/api/helpers/test_errors.py	`92.85% <100%> (ø)`
tests/all/integration/api/helpers/test_auth.py	`97.22% <100%> (ø)`
...all/integration/api/helpers/test_scheduled_jobs.py	`100% <100%> (ø)`
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537a263...642cbab. Read the comment docs.

kushthedude

Please follow Semantic PR Naming for your PR title.

kushthedude · 2019-12-19T17:24:48Z

app/factories/attendee.py

@@ -21,4 +21,5 @@ class Meta:
    is_checked_in = True
    pdf_url = common.url_
    event_id = 1
+    # ticket_id = 1


Remove comment

kushthedude · 2019-12-19T17:25:04Z

app/models/ticket_holder.py

    order_id: int = db.Column(db.Integer, db.ForeignKey('orders.id', ondelete='CASCADE'))
    is_checked_in: bool = db.Column(db.Boolean, default=False)
    is_checked_out: bool = db.Column(db.Boolean, default=False)
    device_name_checkin: str = db.Column(db.String)
    checkin_times: str = db.Column(db.String)
    checkout_times: str = db.Column(db.String)
    attendee_notes: str = db.Column(db.String)
-    event_id: int = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='CASCADE'))
+    event_id: int = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='CASCADE'), nullable=False)


Add migration files for the following.

kushthedude · 2019-12-24T18:44:04Z

docs/api/blueprint/attendees.apib

@@ -73,7 +73,8 @@ Create a new attendee.
                    "country": "IN",
                    "is-checked-in": "false",
                    "attendee-notes": "example",
-                    "pdf-url": "http://example.com"
+                    "pdf-url": "http://example.com",


kushthedude · 2019-12-24T18:44:13Z

docs/api/blueprint/attendees.apib

@@ -73,7 +73,8 @@ Create a new attendee.
                    "country": "IN",
                    "is-checked-in": "false",
                    "attendee-notes": "example",
-                    "pdf-url": "http://example.com"
+                    "pdf-url": "http://example.com",
+                    "ticket-id": "1"


@kushthedude If you explain the problem it would be very helpful

app/factories/attendee.py

iamareebjamal · 2019-12-29T20:41:17Z

tests/hook_main.py

@@ -1858,7 +1858,7 @@ def attendee_post(transaction):
        ticket = TicketFactory()
        db.session.add(ticket)

-        attendee = AttendeeFactory(ticket_id=1)
+        attendee = AttendeeFactory(ticket_id=1, event_id=1)


It's the default value. Not needed

iamareebjamal · 2019-12-29T20:42:37Z

docs/api/blueprint/attendees.apib

-                    "pdf-url": "http://example.com"
+                    "pdf-url": "http://example.com",
+                    "ticket-id": "1",
+                    "event-id": "1"


Updated the fields ticket_id and event_id to be not null

prateekj117 · 2020-01-01T15:16:24Z

app/api/schema/attendees.py

@@ -50,7 +50,6 @@ def validate_json(self, data, original_data):
    gender = fields.Str(allow_none=True)
    birth_date = fields.DateTime(allow_none=True)

-    ticket_id = fields.Str(allow_none=True)


Undo this and run the tests.

@iamareebjamal I think the tests are failing due to this.

I have tried it. The issue still persists.

…server into fix-6665

houndci-bot · 2020-01-04T15:53:01Z

app/models/ticket_holder.py

@@ -37,15 +37,15 @@ class TicketHolder(SoftDeletionModel):
    gender: str = db.Column(db.String)
    birth_date: datetime = db.Column(db.DateTime(timezone=True))
    pdf_url: str = db.Column(db.String)
-    ticket_id: int = db.Column(db.Integer, db.ForeignKey('tickets.id', ondelete='CASCADE'))
+    ticket_id: int = db.Column(db.Integer, db.ForeignKey('tickets.id', ondelete='CASCADE'), nullable=False)


Black would make changes.

iamareebjamal · 2020-01-04T15:55:35Z

app/api/attendees.py

+
+        # populate event id and ticket id
+        data['ticket_id'] = ticket.id
+        data['event_id'] = ticket.event_id


Hi @iamareebjamal I am trying to debug what is the exact reason of the ticket_id and event_id becoming null after the object creation. That's why I tried passing them in the data payload. Any you help me find out what can be the exact reason? Am I going in the right direction as per tracing the problem?

iamareebjamal · 2020-01-05T11:04:39Z

app/api/schema/attendees.py

@@ -93,7 +93,7 @@ class Meta:
                          self_view_kwargs={'id': '<id>'},
                          related_view='v1.ticket_detail',
                          related_view_kwargs={'attendee_id': '<id>'},
-                          schema='TicketSchemaPublic',
+                          schema='TicketSchema',


Can you please stop hit and trial. This is not needed and wrong

iamareebjamal · 2020-05-09T19:55:13Z

Stale

codedsun reviewed Dec 17, 2019

View reviewed changes

app/factories/attendee.py Show resolved Hide resolved

codedsun requested changes Dec 17, 2019

View reviewed changes

codedsun requested changes Dec 19, 2019

View reviewed changes

ashwani99 force-pushed the fix-6665 branch from 7021ba0 to ec07217 Compare December 19, 2019 07:42

kushthedude suggested changes Dec 19, 2019

View reviewed changes

ashwani99 force-pushed the fix-6665 branch 2 times, most recently from 5aeac31 to 9028721 Compare December 22, 2019 16:18

kushthedude reviewed Dec 24, 2019

View reviewed changes

ashwani99 force-pushed the fix-6665 branch 5 times, most recently from e5012a1 to ef88094 Compare December 29, 2019 20:37

iamareebjamal reviewed Dec 29, 2019

View reviewed changes

ashwani99 added 6 commits December 31, 2019 23:26

Update ticket_holder table schema

38736de

Updated the fields ticket_id and event_id to be not null

revert unnecessary changes

49a6815

revert attendee schema changes

83c5333

remove ticket_id null value allowance from attendee schema

2405d7a

create default event before creating attendee

5f1adf8

Remove ticket factory call in dredd hook

144bf29

ashwani99 force-pushed the fix-6665 branch from 280f1a5 to 144bf29 Compare December 31, 2019 17:57

prateekj117 suggested changes Jan 1, 2020

View reviewed changes

ashwani99 added 2 commits January 4, 2020 21:20

Populate event_id and ticket_id while creating attendees

537a263

Merge branch 'development' of https://github.com/fossasia/open-event-…

c6d423d

…server into fix-6665

houndci-bot reviewed Jan 4, 2020

View reviewed changes

iamareebjamal reviewed Jan 4, 2020

View reviewed changes

ashwani99 added 2 commits January 5, 2020 12:08

Change TicketSchemaPublic to TicketSchema

f24b94c

fix attendee related view

642cbab

iamareebjamal reviewed Jan 5, 2020

View reviewed changes

iamareebjamal closed this May 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ticket_holder table schema #6675

Update ticket_holder table schema #6675

ashwani99 commented Dec 17, 2019

codedsun Dec 17, 2019

ashwani99 Dec 18, 2019

codedsun left a comment

vishakhanihore commented Dec 17, 2019

codedsun left a comment •

edited

Loading

codecov bot commented Dec 19, 2019 •

edited

Loading

kushthedude left a comment

kushthedude Dec 19, 2019

kushthedude Dec 19, 2019

kushthedude Dec 24, 2019

kushthedude Dec 24, 2019

ashwani99 Dec 25, 2019

iamareebjamal Dec 29, 2019

iamareebjamal Dec 29, 2019

prateekj117 Jan 1, 2020

prateekj117 Jan 1, 2020

ashwani99 Jan 1, 2020

houndci-bot Jan 4, 2020

iamareebjamal Jan 4, 2020

ashwani99 Jan 5, 2020

iamareebjamal Jan 5, 2020

iamareebjamal commented May 9, 2020

Update ticket_holder table schema #6675

Update ticket_holder table schema #6675

Conversation

ashwani99 commented Dec 17, 2019

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codedsun left a comment

Choose a reason for hiding this comment

vishakhanihore commented Dec 17, 2019

codedsun left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2019 • edited Loading

Codecov Report

kushthedude left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamareebjamal commented May 9, 2020

codedsun left a comment •

edited

Loading

codecov bot commented Dec 19, 2019 •

edited

Loading