chore: Add pytype #6839
Merged
chore: Add pytype #6839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 13, 2020
| @@ -33,7 +33,9 @@ def match_discount_quantity(discount_code, tickets=None, ticket_holders=None): | |||
| qty = 0 | |||
| ticket_ids = [ticket.id for ticket in discount_code.tickets] | |||
| old_holders = get_count( | |||
| TicketHolder.query.filter(TicketHolder.ticket_id.in_(ticket_ids)) | |||
| TicketHolder.query.filter( | |||
| TicketHolder.ticket_id.in_(ticket_ids) # pytype: disable=attribute-error | |||
|
Issues
======
+ Solved 3
- Added 1
Complexity increasing per file
==============================
- app/api/helpers/utilities.py 1
- app/api/helpers/permission_manager.py 1
Complexity decreasing per file
==============================
+ app/settings/__init__.py -6
+ app/models/helpers/versioning.py -23
See the complete overview on Codacy |
niranjan94
reviewed
Feb 14, 2020
| @@ -384,7 +385,7 @@ def import_event_json(task_handle, zip_path, creator_id): | |||
| except IOError: | |||
| db.session.delete(new_event) | |||
| db.session.commit() | |||
| raise NotFoundError('File %s missing in event zip' % item[0]) | |||
| raise NotFoundError('file', 'File %s missing in event zip' % item[0]) | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## development #6839 +/- ##
===============================================
+ Coverage 65.86% 66.21% +0.34%
===============================================
Files 307 307
Lines 15382 15298 -84
===============================================
- Hits 10131 10129 -2
+ Misses 5251 5169 -82
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.