Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cron entries of period tasks #6850

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix: Cron entries of period tasks #6850

merged 1 commit into from
Feb 20, 2020

Conversation

iamareebjamal
Copy link
Member

Fixes #6826

@auto-label auto-label bot added the fix label Feb 19, 2020
@iamareebjamal
Copy link
Member Author

Almost every cron entry was wrong. And I don't blame anyone. Took me an hour to guess what the period should be, is it actually that period or is it a bug of the author

@kushthedude @mrsaicharan1 Please see my comments and confirm this is what it should be. This is what was happening in APS before moving to celery integration.

I don't get the point of 5:00 and 5:30, anyone reading the previous code will assume that it is supposed to run every 5 hours or 5 hours 30 minutes, whereas it actually runs at 5:00/5:30 every day. That's why it caused confusion when migrating to celery. I really hope it is not to sync with +5:30 timezone of India, that would be very embarrasing

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #6850 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6850   +/-   ##
============================================
  Coverage        66.21%   66.21%           
============================================
  Files              307      307           
  Lines            15298    15298           
============================================
  Hits             10129    10129           
  Misses            5169     5169
Impacted Files Coverage Δ
app/api/helpers/scheduled_jobs.py 48.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c3a3c...f1cafdb. Read the comment docs.

@iamareebjamal
Copy link
Member Author

@kushthedude Can you please tell if you know something about this so we can make it live on production?

@iamareebjamal
Copy link
Member Author

Merging since getting no response

@iamareebjamal iamareebjamal merged commit ee271ba into development Feb 20, 2020
@iamareebjamal iamareebjamal deleted the cron branch February 20, 2020 08:04
@kushthedude
Copy link
Member

@kushthedude Can you please tell if you know something about this so we can make it live on production?

@iamareebjamal I was travelling, hence could not give any response before seeing the actual code.
I don't know why 5:30/5:00 why is added. I think it is actually correct now as it makes no sense in sending the after event mail after every 5 hours.
Still, @mrsaicharan1 may know more if I am wrong/missed something.

@iamareebjamal
Copy link
Member Author

OK. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Event Mail: Mails are getting sent in every 5 hours.
2 participants