fix: keyerror due to my_tickets_url while rendering tickets template #6858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 20, 2020
| @@ -190,7 +190,7 @@ | |||
| u"<br/>Your order has been processed successfully." | |||
| + u"<br/> Your tickets & invoice have been enclosed." | |||
| u"<br><br>You can also download your tickets in <b>My Tickets</b> section." | |||
| u"<br/>Login to manage the orders at <a href='{mytickets_url}' target='_blank'>{mytickets_url}</a> </em>" | |||
| u"<br/>Login to manage the orders at <a href='{my_tickets_url}' target='_blank'>{my_tickets_url}</a> </em>" | |||
There was a problem hiding this comment.
line too long (119 > 90 characters)
Codecov Report
@@ Coverage Diff @@
## master #6858 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 307 307
Lines 15298 15298
=======================================
Hits 10129 10129
Misses 5169 5169
Continue to review full report at Codecov.
|
|
Didn't @mrsaicharan1 right a test for this? Then how did this basic mistake get through? |
iamareebjamal
changed the title
iamareebjamal
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6857