Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary comprehension #6900

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

deepsource-autofix[bot]
Copy link
Contributor

No description provided.

@@ -10,8 +10,8 @@ def status_summary(orders, status):
dictionary
"""
return {
'sales_total': sum([o.amount for o in orders if o.status == status]),
'ticket_count': sum([o.tickets_count for o in orders if o.status == status]),
'sales_total': sum(o.amount for o in orders if o.status == status),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@iamareebjamal iamareebjamal changed the title Remove unnecessary comprehension chore: Remove unnecessary comprehension Mar 27, 2020
@auto-label auto-label bot added the chore label Mar 27, 2020
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #6900 into development will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6900   +/-   ##
============================================
  Coverage        66.32%   66.32%           
============================================
  Files              308      308           
  Lines            15321    15321           
============================================
  Hits             10162    10162           
  Misses            5159     5159
Impacted Files Coverage Δ
app/api/admin_sales/utils.py 40% <ø> (ø) ⬆️
app/models/event.py 81.27% <ø> (ø) ⬆️
app/api/admin_sales/fees.py 90.32% <0%> (ø) ⬆️
app/models/order.py 90.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40318a3...e77c7d4. Read the comment docs.

@iamareebjamal iamareebjamal merged commit cd744b6 into development Mar 27, 2020
@iamareebjamal iamareebjamal deleted the deepsource-fix-a629e43c branch March 27, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants