Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Integrate Sentry APM tracing #6901

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

imskr
Copy link
Member

@imskr imskr commented Mar 28, 2020

Fixes #6892

Short description of what this resolves:

Enable APM tracing

Changes proposed in this pull request:

  • Added traces_sample_rate to non-zero

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@iamareebjamal
Copy link
Member

And enable SQLAlchemy integration

@imskr
Copy link
Member Author

imskr commented Mar 28, 2020

And enable SQLAlchemy integration

Its already there

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #6901 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6901   +/-   ##
============================================
  Coverage        66.34%   66.34%           
============================================
  Files              308      308           
  Lines            15327    15327           
============================================
  Hits             10168    10168           
  Misses            5159     5159
Impacted Files Coverage Δ
app/instance.py 87.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd744b6...ec960a5. Read the comment docs.

@iamareebjamal iamareebjamal changed the title Integrate Sentry APM tracing chore: Integrate Sentry APM tracing Mar 28, 2020
@auto-label auto-label bot added the chore label Mar 28, 2020
@iamareebjamal iamareebjamal merged commit 1b6d2fd into fossasia:development Mar 28, 2020
@imskr imskr deleted the skr-apm branch March 28, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Sentry APM tracing
2 participants