Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initialize alpha GraphQL support #6902

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Mar 29, 2020

Fix for #6903

@auto-label auto-label bot added the feature label Mar 29, 2020
def test_extracts_fields(self):
self.assertTrue(
set(extract_from_marshmallow(SettingSchemaPublic)).issuperset(
set(['id', 'app_name', 'is_paytm_activated'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.


def init_app(app):
app.add_url_rule(
"/graphql", view_func=GraphQLView.as_view("graphql", schema=schema, graphiql=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/graphql/types/settings/schema.py  1
- app/graphql/utils/fields.py  1
- tests/all/unit/graphql/utils/test_fields.py  1
- app/graphql/views.py  1
- app/graphql/schema.py  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #6902 into development will increase coverage by 0.05%.
The diff coverage is 96.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6902      +/-   ##
===============================================
+ Coverage        66.34%   66.40%   +0.05%     
===============================================
  Files              308      313       +5     
  Lines            15330    15358      +28     
===============================================
+ Hits             10171    10198      +27     
- Misses            5159     5160       +1     
Impacted Files Coverage Δ
app/graphql/schema.py 87.50% <87.50%> (ø)
app/graphql/types/settings/schema.py 100.00% <100.00%> (ø)
app/graphql/utils/fields.py 100.00% <100.00%> (ø)
app/graphql/views.py 100.00% <100.00%> (ø)
app/instance.py 87.50% <100.00%> (-0.15%) ⬇️
tests/all/unit/graphql/utils/test_fields.py 100.00% <100.00%> (ø)
app/api/helpers/ticketing.py 23.47% <0.00%> (-0.66%) ⬇️
app/models/helpers/versioning.py 96.00% <0.00%> (-0.43%) ⬇️
populate_db.py 90.52% <0.00%> (-0.05%) ⬇️
app/models/event.py 81.27% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d68cf33...d325ebc. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 92d7af3 into fossasia:development Mar 29, 2020
@iamareebjamal iamareebjamal deleted the graphql branch March 29, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants