Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle ticket fee not found error in send monthly invoice #6924

Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix: Handle ticket fee not found error in send monthly invoice #6924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/api/helpers/scheduled_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import pytz
from dateutil.relativedelta import relativedelta
from sqlalchemy.orm.exc import NoResultFound
from flask_rest_jsonapi.exceptions import ObjectNotFound
from flask import render_template
from flask_celeryext import RequestContextTask

Expand Down Expand Up @@ -32,7 +31,9 @@
from app.models.ticket_fee import TicketFees, get_fee
from app.models.ticket_holder import TicketHolder
from app.settings import get_settings
import logging

logger = logging.getLogger(__name__)

@celery.task(base=RequestContextTask, name='send.after.event.mail')
def send_after_event_mail():
Expand Down Expand Up @@ -256,9 +257,9 @@ def send_monthly_event_invoice():
db.session.query(TicketFees).filter_by(currency=currency).one()
)
except NoResultFound:
raise ObjectNotFound(
{'source': ''}, 'Ticket Fee not set for {}'.format(currency)
)
logger.error('Ticket Fee not found for event id {id}'.format(id=event.id))
continue

ticket_fee_percentage = ticket_fee_object.service_fee
ticket_fee_maximum = ticket_fee_object.maximum_fee
orders = Order.query.filter_by(event=event).all()
Expand Down