Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update max line length in .deepsource.toml #6980

Merged
merged 1 commit into from
May 7, 2020

Conversation

pnijhara
Copy link
Member

@pnijhara pnijhara commented May 7, 2020

Fixes #6978

Short description of what this resolves:

This PR adds max_line_check = 90 to .deepsource.toml

Changes proposed in this pull request:

By default, DeepSource checks max line length for python file to be 88. However, this can be updated as per the project requirement by adding a line max_line_check under [analyzers.meta] tag in .deepsource.toml.

Refer https://deepsource.io/docs/analyzer/python.html#configuration-deepsource-toml

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the chore label May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #6980 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6980   +/-   ##
============================================
  Coverage        60.87%   60.87%           
============================================
  Files              259      259           
  Lines            13564    13564           
============================================
  Hits              8257     8257           
  Misses            5307     5307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673960f...8a82e56. Read the comment docs.

@pnijhara
Copy link
Member Author

pnijhara commented May 7, 2020

@prateekj117, please review it.

@prateekj117 prateekj117 merged commit 67f4af6 into fossasia:development May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change max line length in deepsource config.
2 participants