Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove useless __init__ from models #6985

Merged
merged 3 commits into from
May 8, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ app/models/custom_system_role.py  -4
+ app/models/mail.py  -1
+ app/models/ticket.py  -2
+ app/models/speakers_call.py  -2
+ app/models/activity.py  -1
+ app/models/panel_permission.py  -1
+ app/models/users_events_role.py  -6
         

Clones removed
==============
+ app/models/access_code.py  -1
+ app/models/discount_code.py  -1
+ app/models/custom_system_role.py  -1
+ app/models/users_events_role.py  -1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #6985 into development will decrease coverage by 0.72%.
The diff coverage is 90.27%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6985      +/-   ##
===============================================
- Coverage        60.54%   59.82%   -0.73%     
===============================================
  Files              259      259              
  Lines            13649    12875     -774     
===============================================
- Hits              8264     7702     -562     
+ Misses            5385     5173     -212     
Impacted Files Coverage Δ
app/api/event_locations.py 51.72% <0.00%> (ø)
app/api/events.py 21.70% <0.00%> (ø)
app/api/helpers/files.py 73.71% <ø> (ø)
app/api/role_invites.py 42.47% <0.00%> (ø)
app/models/custom_form.py 96.15% <ø> (+3.47%) ⬆️
app/models/custom_form_option.py 87.50% <ø> (+20.83%) ⬆️
app/models/email_notification.py 93.75% <ø> (+29.75%) ⬆️
app/models/event_copyright.py 93.75% <ø> (+31.68%) ⬆️
app/models/event_orga.py 0.00% <0.00%> (ø)
app/models/faq.py 90.00% <ø> (+28.09%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a043e3...462f4f8. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 05fc6d2 into fossasia:development May 8, 2020
@iamareebjamal iamareebjamal deleted the model-thin branch May 8, 2020 19:48
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 8, 2020

This pull request introduces 1 alert when merging 462f4f8 into 2a043e3 - view on LGTM.com

new alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants