test: Validation of tickets, discount code #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iamareebjamal
commented
May 14, 2020
iamareebjamal
commented
- Deduplicate validation logic
- Test validation of ticket, attendees and discount
- Validate discount code in calculate_order_amount
- Fix multiple issues related to deleted items
- Simplify validation interface of discount
houndci-bot
reviewed
May 14, 2020
|
|
||
| order_without_discount = OrderFactory(status='completed') | ||
| order_without_discount = OrderFactory(status='completed') |
| db.session.commit() | ||
|
|
||
| with pytest.raises( | ||
| UnprocessableEntity, match=r'All tickets must belong to same event. Found: .*' |
|
|
||
| with pytest.raises( | ||
| ConflictException, | ||
| match=f'Order already exists for attendee with id {attendees[-1].id}', |
| discount = DiscountCodeTicketSubFactory(tickets_number=5, tickets=tickets) | ||
| db.session.commit() | ||
|
|
||
| return discount, [{'id': ticket.id} for ticket in tickets] |
app/api/helpers/ticketing.py
Outdated
| ) | ||
| ticket_events = {ticket.event_id for ticket in fetched_tickets} | ||
| if len(ticket_events) != 1: | ||
| logger.warning("Tickets with different event IDs requested for Order", extra=dict(ticket_events=ticket_events)) |
There was a problem hiding this comment.
line too long (119 > 90 characters)
app/api/helpers/ticketing.py
Outdated
| for ticket_holder in ticket_holders: | ||
| # Ensuring that the attendee exists and doesn't have an associated order. | ||
| if ticket_holder.order_id: | ||
| logger.warning("Order already exists for attendee", extra=dict(attendee_id=ticket_holder.id)) |
There was a problem hiding this comment.
line too long (105 > 90 characters)
app/api/helpers/ticketing.py
Outdated
| ) | ||
|
|
||
| if len(ticket_holders) != len(ticket_holder_ids): | ||
| logger.warning("Ticket Holders not found in", extra=dict(ticket_holder_ids=ticket_holder_ids)) |
There was a problem hiding this comment.
Black would make changes.
line too long (102 > 90 characters)
- Deduplicate validation logic - Test validation of ticket, attendees and discount - Validate discount code in calculate_order_amount - Fix multiple issues related to deleted items - Simplify validation interface of discount
iamareebjamal
force-pushed
the
test/discount-validation
branch
from
f4586dc to
ea3f0e7
Compare
houndci-bot
reviewed
May 14, 2020
|
|
||
| if len(ticket_holders) != len(ticket_holder_ids): | ||
| logger.warning( | ||
| "Ticket Holders not found in", extra=dict(ticket_holder_ids=ticket_holder_ids) |
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- tests/all/integration/api/helpers/order/test_validate_tickets.py 3
- tests/all/integration/api/helpers/order/test_validate_discount_code.py 4
- tests/all/integration/api/helpers/order/test_validate_ticket_holders.py 3
- tests/all/integration/api/helpers/test_ticketing.py 2
- app/models/discount_code.py 1
- app/api/helpers/ticketing.py 1
Complexity decreasing per file
==============================
+ app/api/helpers/order.py -1
See the complete overview on Codacy |
niranjan94
reviewed
May 14, 2020
| assert validate_discount_code(str(discount.id), tickets=tickets) == discount | ||
|
|
||
|
|
||
| def test_validate_discount_code_require_tickets_or_holders(db): |
There was a problem hiding this comment.
niranjan94
reviewed
May 14, 2020
| discount.validate(tickets=[{'id': ticket.id} for ticket in deleted_tickets]) | ||
|
|
||
|
|
||
| def test_validate_discount_code_accept_mix_deleted_tickets(db): |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## development #7004 +/- ##
===============================================
+ Coverage 60.30% 60.56% +0.26%
===============================================
Files 259 259
Lines 12853 12893 +40
===============================================
+ Hits 7751 7809 +58
+ Misses 5102 5084 -18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.