-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent arbitrary order update #7056
fix: Prevent arbitrary order update #7056
Conversation
} | ||
}}} | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line contains whitespace
} | ||
] | ||
} | ||
}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line missing indentation or outdented
data=json.dumps( | ||
{'data': {'type': 'order', 'id': order_id, | ||
"relationships": { | ||
"attendees": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line missing indentation or outdented
|
||
data=json.dumps( | ||
{'data': {'type': 'order', 'id': order_id, | ||
"relationships": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line under-indented for visual indent
attendee = AttendeeSubFactory() | ||
db.session.commit() | ||
|
||
data=json.dumps( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing whitespace around operator
db.session.commit() | ||
|
||
response = client.post( | ||
'/v1/orders/create-order', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black would make changes.
import json | ||
|
||
from app.models.order import Order | ||
from tests.factories.discount_code import DiscountCodeTicketSubFactory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tests.factories.discount_code.DiscountCodeTicketSubFactory' imported but unused
|
||
|
||
def create_order(db, user): | ||
order = OrderSubFactory(amount=234, status='initializing', user=user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black would make changes.
from tests.factories.event import EventFactoryBasic | ||
from tests.factories.order import OrderSubFactory | ||
|
||
from .test_calculate_order_amount import _create_taxed_tickets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'.test_calculate_order_amount._create_taxed_tickets' imported but unused
Complexity increasing per file
==============================
- tests/all/integration/api/helpers/order/test_edit_order.py 4
See the complete overview on Codacy |
Codecov Report
@@ Coverage Diff @@
## development #7056 +/- ##
===============================================
+ Coverage 61.17% 61.59% +0.41%
===============================================
Files 260 260
Lines 12884 12890 +6
===============================================
+ Hits 7882 7939 +57
+ Misses 5002 4951 -51
Continue to review full report at Codecov.
|
Workaround for #7055