feat: Add name to custom form fields #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 20, 2020
| for form, dict_map in CUSTOM_FORM_IDENTIFIER_NAME_MAP.items(): | ||
| for identifier, name in dict_map.items(): | ||
| statements.append( | ||
| f"UPDATE custom_forms SET name = '{name}' WHERE form = '{form}' and field_identifier = '{identifier}';" |
There was a problem hiding this comment.
line too long (119 > 90 characters)
| def test_custom_form_name(db): | ||
| event = EventFactoryBasic() | ||
| speaker_custom_form = CustomForms( | ||
| event=event, field_identifier='speakingExperience', form='speaker', type='text' |
| @@ -11,6 +12,9 @@ | |||
|
|
|||
| class DiscountCode(SoftDeletionModel): | |||
| __tablename__ = "discount_codes" | |||
| __table_args__ = ( | |||
| UniqueConstraint('event_id', 'code', name='uq_event_discount_code'), | |||
houndci-bot
reviewed
Jun 20, 2020
| @@ -11,8 +11,8 @@ class Meta: | |||
| model = CustomForms | |||
|
|
|||
| event = factory.RelatedFactory(EventFactoryBasic) | |||
| form = common.string_ | |||
| field_identifier = common.string_ | |||
| form = 'attendee' | |||
houndci-bot
reviewed
Jun 20, 2020
| @@ -13,7 +13,7 @@ class Meta: | |||
| model = DiscountCode | |||
|
|
|||
| marketer = factory.RelatedFactory(UserFactory) | |||
| code = common.string_ | |||
| code = factory.Sequence(lambda n: 'john%s' % n) | |||
Codecov Report
@@ Coverage Diff @@
## development #7064 +/- ##
===============================================
+ Coverage 61.59% 61.61% +0.02%
===============================================
Files 260 260
Lines 12890 12914 +24
===============================================
+ Hits 7939 7957 +18
- Misses 4951 4957 +6
Continue to review full report at Codecov.
|
|
Complexity increasing per file
==============================
- tests/all/integration/models/custom_form_tests.py 11
- app/models/custom_form.py 3
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some misc. DB reference fixes