Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add validation for required fields in attendee form #7070

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jun 22, 2020

Fixes #7068
Fixes #7067

Unblocks #7069


data = json.dumps(
{
'data': {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@auto-label auto-label bot added the feature label Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #7070 into development will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7070      +/-   ##
===============================================
+ Coverage        61.66%   61.81%   +0.14%     
===============================================
  Files              260      260              
  Lines            12915    12929      +14     
===============================================
+ Hits              7964     7992      +28     
+ Misses            4951     4937      -14     
Impacted Files Coverage Δ
app/api/schema/attendees.py 100.00% <ø> (+1.69%) ⬆️
app/api/attendees.py 54.26% <100.00%> (+12.73%) ⬆️
app/models/custom_form.py 97.95% <100.00%> (+0.13%) ⬆️
app/api/helpers/permission_manager.py 35.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e6910...02f76cd. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 17ddb87 into development Jun 22, 2020
@iamareebjamal iamareebjamal deleted the custom-form/validate branch June 22, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants