feat: Add speaker custom form logic and validation #7107

iamareebjamal · 2020-07-03T00:00:16Z

houndci-bot · 2020-07-03T00:00:26Z

app/api/speakers.py

@@ -32,14 +34,15 @@ def before_post(self, args, kwargs, data=None):
        :param data:
        :return:
        """
+        data['user'] = current_user.id


Black would make changes.

houndci-bot · 2020-07-03T00:00:26Z

tests/all/integration/api/speaker/test_speaker_api.py

+        city=None,
+        heard_from=None,
+        user=user,
+        event__state='published',


Black would make changes.

codecov · 2020-07-03T11:26:09Z

Codecov Report

Merging #7107 into development will increase coverage by 0.50%.
The diff coverage is 90.00%.

@@               Coverage Diff               @@
##           development    #7107      +/-   ##
===============================================
+ Coverage        62.00%   62.51%   +0.50%     
===============================================
  Files              262      262              
  Lines            13000    13006       +6     
===============================================
+ Hits              8061     8131      +70     
+ Misses            4939     4875      -64

Impacted Files	Coverage Δ
app/models/custom_form.py	`97.95% <0.00%> (ø)`
app/api/attendees.py	`50.42% <100.00%> (ø)`
app/api/helpers/speaker.py	`90.00% <100.00%> (+40.00%)`	⬆️
app/api/speakers.py	`68.93% <100.00%> (+21.50%)`	⬆️
app/api/schema/speakers.py	`100.00% <0.00%> (+2.12%)`	⬆️
app/api/helpers/permission_manager.py	`50.69% <0.00%> (+13.98%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86dd502...fcab543. Read the comment docs.

niranjan94 · 2020-07-03T11:31:50Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- tests/all/integration/api/speaker/test_speaker_api.py  8
         

Clones added
============
- tests/all/integration/api/speaker/test_speaker_api.py  25

See the complete overview on Codacy

niranjan94 · 2020-07-03T11:31:51Z

tests/all/integration/api/speaker/test_speaker_api.py

+    assert speaker.complex_field_values is None
+
+
+def test_custom_form_create_complex_fields_missing_required(db, client, user, jwt):


Codacy found an issue: Function name "test_custom_form_create_complex_fields_missing_required" doesn't conform to '[a-z_][a-z0-9_]{1,50}$' pattern

feat: Add speaker custom form logic and validation

67d82df

auto-label bot added the feature label Jul 3, 2020

houndci-bot reviewed Jul 3, 2020

View reviewed changes

iamareebjamal added 2 commits July 3, 2020 16:42

fix

f762255

fix

fcab543

iamareebjamal merged commit 120d121 into development Jul 3, 2020

iamareebjamal deleted the speaker-custom-form branch July 3, 2020 11:27

niranjan94 reviewed Jul 3, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add speaker custom form logic and validation #7107

feat: Add speaker custom form logic and validation #7107

iamareebjamal commented Jul 3, 2020

houndci-bot Jul 3, 2020

houndci-bot Jul 3, 2020

codecov bot commented Jul 3, 2020 •

edited

Loading

niranjan94 commented Jul 3, 2020

niranjan94 Jul 3, 2020

		assert speaker.complex_field_values is None


		def test_custom_form_create_complex_fields_missing_required(db, client, user, jwt):

feat: Add speaker custom form logic and validation #7107

feat: Add speaker custom form logic and validation #7107

Conversation

iamareebjamal commented Jul 3, 2020

houndci-bot Jul 3, 2020

Choose a reason for hiding this comment

houndci-bot Jul 3, 2020

Choose a reason for hiding this comment

codecov bot commented Jul 3, 2020 • edited Loading

Codecov Report

niranjan94 commented Jul 3, 2020

niranjan94 Jul 3, 2020

Choose a reason for hiding this comment

codecov bot commented Jul 3, 2020 •

edited

Loading