fix: Make attendee info editable only by admin or that user itself #7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add tests for the logic |
app/api/attendees.py
Outdated
|
|
||
| if not (current_user.is_staff or current_user.id == order.user_id): | ||
| raise ForbiddenError( | ||
| {'source': ''}, 'Only admin or that user itself can update attendee info', |
There was a problem hiding this comment.
{'source': ''} is useless. Provide better pointer or remove it altogether
|
Complexity increasing per file
==============================
- app/api/attendees.py 2
Clones added
============
- tests/all/integration/api/attendee/test_attendee_api.py 11
See the complete overview on Codacy |
|
@iamareebjamal Please review |
Codecov Report
@@ Coverage Diff @@
## development #7108 +/- ##
===============================================
+ Coverage 62.51% 62.53% +0.01%
===============================================
Files 262 262
Lines 13006 13008 +2
===============================================
+ Hits 8131 8134 +3
+ Misses 4875 4874 -1
Continue to review full report at Codecov.
|
iamareebjamal
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7104
Short description of what this resolves:
Right now anybody can edit attendee info which is not correct.
Changes proposed in this pull request:
Only admin or that user itself should be able to edit attendee's info.
Checklist
developmentbranch.