fix: Send after event emails and notifs to unique receivers #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #7126 +/- ##
===============================================
- Coverage 62.84% 62.79% -0.06%
===============================================
Files 262 262
Lines 13011 13023 +12
===============================================
+ Hits 8177 8178 +1
- Misses 4834 4845 +11
Continue to review full report at Codecov.
|
app/api/helpers/scheduled_jobs.py
Outdated
| send_notif_after_event(organizer.user, event.name) | ||
| if owner: | ||
| send_email_after_event(owner.user.email, event.name, frontend_url) | ||
| unique_emails.add(owner.user.email) | ||
| send_notif_after_event(owner.user, event.name) |
|
Change in all places where repeatedly sending mails |
Haider8
changed the title
app/api/helpers/scheduled_jobs.py
Outdated
| @@ -54,18 +54,23 @@ def send_after_event_mail(): | |||
| frontend_url = get_settings()['frontend_url'] | |||
| if current_time > event.ends_at and time_difference_minutes < 1440: | |||
| unique_emails = set() | |||
| user_objects = list() | |||
There was a problem hiding this comment.
Suggested change
| user_objects = list() | |
| user_objects = [] |
app/api/helpers/utilities.py
Outdated
| This will return a dict containing unique keys | ||
| mapped to the object which contains that key. | ||
| """ | ||
| mapped_dict = dict() |
There was a problem hiding this comment.
Suggested change
| mapped_dict = dict() | |
| mapped_dict = {} |
…server into issue-several-emails
iamareebjamal
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6731
Short description of what this resolves:
Multiple emails can be sent if the same user is owner, speaker or organizer which is wrong. Only single email should be sent in that case.
Changes proposed in this pull request:
Send after event emails to unique email ids only by creating a
setof unique emails.Checklist
developmentbranch.