feat: Add session state transition validation #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 23, 2020
| assert json.loads(response.data) == { | ||
| 'errors': [ | ||
| { | ||
| 'detail': f'You cannot change a session state from "{state}" to "{new_state}"', |
There was a problem hiding this comment.
line too long (99 > 90 characters)
| owner = new_user | ||
| creator = user | ||
| session = SessionSubFactory(creator_id=creator.id, **kwargs) | ||
| role, _ = get_or_create(Role, name='owner', title_name='Owner') |
| except KeyError: | ||
| raise ForbiddenError( | ||
| {'pointer': '/data/attributes/state'}, | ||
| f'You cannot change a session state from "{session.state}" to "{new_state}"', |
There was a problem hiding this comment.
line too long (97 > 90 characters)
|
Complexity increasing per file
==============================
- tests/all/integration/api/session/test_session_state_api.py 7
Complexity decreasing per file
==============================
+ app/api/schema/sessions.py -3
See the complete overview on Codacy |
Codecov Report
@@ Coverage Diff @@
## development #7156 +/- ##
===============================================
+ Coverage 62.73% 62.84% +0.11%
===============================================
Files 262 262
Lines 13046 13055 +9
===============================================
+ Hits 8184 8205 +21
+ Misses 4862 4850 -12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7149