Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove modules from project #7158

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Fixes #7087

Changes proposed in this pull request:

removed all modules.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 24, 2020
@iamareebjamal
Copy link
Member

Don't remove tickets_url, we don't want to change any API

@snitin315 snitin315 force-pushed the fix/remove-modules branch from 2b81071 to 57ef7f3 Compare July 25, 2020 02:13
@iamareebjamal
Copy link
Member

You have to remove it from API docs as well

@snitin315 snitin315 force-pushed the fix/remove-modules branch from b0def80 to fba0cd9 Compare July 25, 2020 04:18
@niranjan94
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ manage.py  -1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #7158 into development will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7158      +/-   ##
===============================================
+ Coverage        62.85%   62.86%   +0.01%     
===============================================
  Files              262      259       -3     
  Lines            13056    12985      -71     
===============================================
- Hits              8206     8163      -43     
+ Misses            4850     4822      -28     
Impacted Files Coverage Δ
app/api/routes.py 100.00% <ø> (ø)
manage.py 0.00% <ø> (ø)
populate_db.py 90.73% <ø> (+0.21%) ⬆️
app/api/events.py 22.49% <33.33%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf9640...fba0cd9. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 78cdfeb into fossasia:development Jul 25, 2020
@snitin315 snitin315 deleted the fix/remove-modules branch July 25, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove modules from project
4 participants