Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instagram_url in settings model #7163

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

snitin315
Copy link
Member

Short description of what this resolves:

Refers fossasia/open-event-frontend#4617

Changes proposed in this pull request:

Added field for an Instagram link in admin settings.

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Jul 26, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #7163 into development will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7163   +/-   ##
============================================
  Coverage        62.87%   62.87%           
============================================
  Files              259      259           
  Lines            12990    12992    +2     
============================================
+ Hits              8167     8169    +2     
  Misses            4823     4823           
Impacted Files Coverage Δ
app/api/schema/settings.py 100.00% <100.00%> (ø)
app/models/setting.py 86.20% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1033f87...79021b3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 7ce7196 into fossasia:development Jul 26, 2020
@snitin315 snitin315 deleted the feat/instagram branch July 26, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants