fix: Allow organizer to override session form validation #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 30, 2020
| complex_field_values = data.get('complex_field_values', 'absent') # Set default to 'absent' to differentiate between None and not sent | ||
| is_absent = complex_field_values == 'absent' # True if values are not sent in data JSON | ||
| is_same = data.get('complex_field_values') == session.complex_field_values # Using original value to ensure None instead of absent | ||
| # We stop checking validations for organizers only if they may result in data change or absent. See test_session_forms_api.py for more info |
There was a problem hiding this comment.
line too long (147 > 90 characters)
app/api/sessions.py
Outdated
| # We allow organizers and admins to edit session without validations | ||
| complex_field_values = data.get('complex_field_values', 'absent') # Set default to 'absent' to differentiate between None and not sent | ||
| is_absent = complex_field_values == 'absent' # True if values are not sent in data JSON | ||
| is_same = data.get('complex_field_values') == session.complex_field_values # Using original value to ensure None instead of absent |
There was a problem hiding this comment.
at least two spaces before inline comment
line too long (138 > 90 characters)
app/api/sessions.py
Outdated
| ) | ||
| # We allow organizers and admins to edit session without validations | ||
| complex_field_values = data.get('complex_field_values', 'absent') # Set default to 'absent' to differentiate between None and not sent | ||
| is_absent = complex_field_values == 'absent' # True if values are not sent in data JSON |
There was a problem hiding this comment.
at least two spaces before inline comment
line too long (95 > 90 characters)
app/api/sessions.py
Outdated
| 'session', self.resource.schema, session, data | ||
| ) | ||
| # We allow organizers and admins to edit session without validations | ||
| complex_field_values = data.get('complex_field_values', 'absent') # Set default to 'absent' to differentiate between None and not sent |
There was a problem hiding this comment.
at least two spaces before inline comment
line too long (142 > 90 characters)
houndci-bot
reviewed
Jul 30, 2020
| 'data': { | ||
| 'type': 'session', | ||
| 'id': str(session.id), | ||
| "attributes": {"state": "withdrawn",}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7164