Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove location and online checks for event #7229

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Aug 28, 2020

For fossasia/open-event-frontend#4611

Now there's no need for check for the location with online events present.

location, no online - normal
location, online - mixed
no location, online - online
no location, no online - TBD

All possible states are valid

@auto-label auto-label bot added the fix label Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #7229 into development will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7229      +/-   ##
===============================================
+ Coverage        62.98%   63.02%   +0.04%     
===============================================
  Files              259      259              
  Lines            13043    13034       -9     
===============================================
  Hits              8215     8215              
+ Misses            4828     4819       -9     
Impacted Files Coverage Δ
app/api/events.py 23.00% <ø> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e44870...beb6c96. Read the comment docs.

@iamareebjamal iamareebjamal merged commit d14682c into development Aug 28, 2020
@mariobehling mariobehling deleted the online-event-check branch August 29, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant