Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Enable dredd tests for event role permissions API #7231

Merged
merged 1 commit into from
Aug 28, 2020
Merged

chore(tests): Enable dredd tests for event role permissions API #7231

merged 1 commit into from
Aug 28, 2020

Conversation

blossom2017
Copy link
Contributor

#7014

Short description of what this resolves:

Enables dredd tests for event role permissions API.

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@@ -19,6 +19,7 @@

# imports from factories

from tests.factories.event_role_permission import EventRolePermissionsFactory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module level import not at top of file

@@ -16,7 +16,7 @@ class Meta:
Meta class for Notification API schema
"""

type_ = 'event-role-permission'
type_ = 'event-role-permissions'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #7231 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7231   +/-   ##
============================================
  Coverage        63.02%   63.02%           
============================================
  Files              259      259           
  Lines            13034    13034           
============================================
  Hits              8215     8215           
  Misses            4819     4819           
Impacted Files Coverage Δ
app/api/schema/event_role_permissions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14682c...4d0a37e. Read the comment docs.

@iamareebjamal iamareebjamal changed the title Enable dredd tests for event role permissions API chore(tests): Enable dredd tests for event role permissions API Aug 28, 2020
@iamareebjamal iamareebjamal merged commit a5bfb3f into fossasia:development Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants