fix: Remove editing role invites #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 3, 2020
app/api/role_invites.py
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from app.api.bootstrap import api | |||
| from app.api.helpers.db import save_to_db | |||
| from app.api.helpers.errors import ForbiddenError, NotFoundError, UnprocessableEntityError | |||
| from app.api.helpers.errors import ConflictError, ForbiddenError, NotFoundError, UnprocessableEntityError | |||
There was a problem hiding this comment.
'app.api.helpers.errors.UnprocessableEntityError' imported but unused
Black would make changes.
line too long (105 > 90 characters)
mansiag
changed the title
|
This pull request introduces 1 alert when merging 4d97d60 into 3a3e4d1 - view on LGTM.com new alerts:
|
app/api/role_invites.py
Outdated
| {'source': ''}, "You can only change your status" | ||
| if role_invite.status == 'accepted': | ||
| raise ConflictError( | ||
| {'source': ''}, 'You cannot delete an accepted role invite.' |
There was a problem hiding this comment.
Suggested change
| {'source': ''}, 'You cannot delete an accepted role invite.' | |
| {'pointer': '/data/status'}, 'You cannot delete an accepted role invite.' |
Codecov Report
@@ Coverage Diff @@
## development #7240 +/- ##
===============================================
+ Coverage 63.02% 63.09% +0.06%
===============================================
Files 259 259
Lines 13034 13022 -12
===============================================
+ Hits 8215 8216 +1
+ Misses 4819 4806 -13
Continue to review full report at Codecov.
|
vsasvipul0605
approved these changes
Sep 13, 2020
iamareebjamal
approved these changes
Nov 14, 2020
iamareebjamal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7235
Short description of what this resolves:
Since editing role invites on the dashboard, doesn't cause any change in the backend, so removes the option of editing role invites and deleting accepted role invites.
Checklist
developmentbranch.