chore: Enable dredd tests for some of the Orders API endpoints #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 11, 2020
| discount_code = DiscountCodeTicketSubFactory( | ||
| type='percent', value=10.0, tickets=[] | ||
| ) | ||
| tickets_dict = _create_taxed_tickets( |
There was a problem hiding this comment.
local variable 'tickets_dict' is assigned to but never used
| from tests.factories.faq_type import FaqTypeFactory | ||
| from tests.factories.user_email import UserEmailFactory | ||
| from tests.factories.feedback import FeedbackFactory | ||
| from tests.factories.service import ServiceFactory | ||
| from tests.factories.message_setting import MessageSettingsFactory | ||
| from tests.factories.user_favourite_events import UserFavouriteEventFactory | ||
| from tests.factories.discount_code import DiscountCodeTicketSubFactory | ||
|
|
||
| from tests.all.integration.api.helpers.order.test_calculate_order_amount import ( |
There was a problem hiding this comment.
module level import not at top of file
blossom2017
changed the title
| @@ -167,7 +167,7 @@ def create_order(): | |||
| db.session.commit() | |||
| order.populate_and_save() | |||
|
|
|||
| return OrderSchema().dumps(order) | |||
| return OrderSchema().dump(order) | |||
There was a problem hiding this comment.
Why dump instead of dumps?
There was a problem hiding this comment.
dumps was returning a string -> content/html whereas dump returned dictionary application/json. I saw that in the other places dump had been used.
docs/api/blueprint/order/orders.apib
Outdated
| @@ -793,3 +626,114 @@ Create paypal payment | |||
| "payment_id": "example", | |||
| "error": null | |||
| } | |||
|
|
|||
| ## Create Order [/v1/orders/create-order] | |||
There was a problem hiding this comment.
This should be placed in create order (1st section) place
houndci-bot
reviewed
Sep 12, 2020
| @@ -33,7 +33,11 @@ | |||
| from tests.factories.event_copyright import EventCopyrightFactory | |||
| from tests.factories.setting import SettingFactory | |||
| from tests.factories.event_type import EventTypeFactory | |||
| from tests.factories.discount_code import DiscountCodeFactory, DiscountCodeTicketFactory | |||
| from tests.factories.discount_code import ( | |||
There was a problem hiding this comment.
module level import not at top of file
Codecov Report
@@ Coverage Diff @@
## development #7261 +/- ##
============================================
Coverage 63.55% 63.55%
============================================
Files 259 259
Lines 13034 13034
============================================
Hits 8284 8284
Misses 4750 4750
Continue to review full report at Codecov.
|
blossom2017
changed the title
iamareebjamal
changed the title
iamareebjamal
changed the title
iamareebjamal
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7014
#7005
Short description of what this resolves:
Adds dredd tests for Orders API that were being skipped
Changes proposed in this pull request:
Checklist
developmentbranch.