Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Round money in order/invoice instead of int #7294

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 28, 2020

For fossasia/open-event-frontend#5127

Previously, amount was converted to int, so instead of paying 13.45, people paid 13

@auto-label auto-label bot added the fix label Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #7294 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #7294   +/-   ##
============================================
  Coverage        63.93%   63.93%           
============================================
  Files              259      259           
  Lines            13043    13043           
============================================
  Hits              8339     8339           
  Misses            4704     4704           
Impacted Files Coverage Δ
app/api/users.py 29.14% <ø> (ø)
app/api/helpers/payment.py 24.20% <100.00%> (ø)
app/api/helpers/utilities.py 70.93% <100.00%> (+1.05%) ⬆️
app/models/event_invoice.py 93.47% <100.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92c444...4cf0435. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 28, 2020

This pull request introduces 1 alert when merging 59e3e20 into b92c444 - view on LGTM.com

new alerts:

  • 1 for Unused import

@iamareebjamal iamareebjamal merged commit ed62514 into fossasia:development Sep 28, 2020
@iamareebjamal iamareebjamal deleted the round-money branch September 28, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant