Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configure paypal on charge request #7305

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Sep 30, 2020

Fixes #6872

The charge function was missing the paypal configure method call. And so, in case payment create and charge requests were handled by the same worker, then everything worked correctly since the configuration was done on the payment creation call, so the worker got configured for the charge request. But in case, charge request was handled by a new worker which did not create the payment, it would be uninitialized with the config, hence throw the error. This was fixed by using environment variables as they are global

@auto-label auto-label bot added the fix label Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #7305 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7305      +/-   ##
===============================================
- Coverage        64.00%   63.99%   -0.01%     
===============================================
  Files              259      259              
  Lines            13075    13076       +1     
===============================================
  Hits              8368     8368              
- Misses            4707     4708       +1     
Impacted Files Coverage Δ
app/api/helpers/payment.py 24.05% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a8dab...bc4d162. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 12f6e06 into development Sep 30, 2020
@iamareebjamal iamareebjamal deleted the paypal-configure branch September 30, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paypal integration not working: MissingConfig
1 participant