fix: Correct invoice permissions and disable post, patch, delete #7312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 2, 2020
|
|
||
|
|
||
| def test_invoice_post_user_error(client, jwt): | ||
| data = json.dumps({'data': {'type': 'event-invoice', 'attributes': {'amount': 100},}}) |
|
|
||
|
|
||
| def test_invoice_post_admin_error(client, admin_jwt): | ||
| data = json.dumps({'data': {'type': 'event-invoice', 'attributes': {'amount': 100},}}) |
| get_invoice(db, user) | ||
|
|
||
| response = client.get( | ||
| '/v1/event-invoices', content_type='application/vnd.api+json', headers=jwt, |
| @@ -4,17 +4,14 @@ | |||
| from flask_jwt_extended import current_user | |||
| from flask_rest_jsonapi import ResourceDetail, ResourceList, ResourceRelationship | |||
|
|
|||
| from app.api.bootstrap import api | |||
| from app.api.helpers.db import safe_query, safe_query_kwargs, save_to_db | |||
| from app.api.helpers.db import safe_query, safe_query_by_id, safe_query_kwargs, save_to_db | |||
iamareebjamal
force-pushed
the
invoice-permissions
branch
from
46f08c3 to
d97ca68
Compare
Codecov Report
@@ Coverage Diff @@
## development #7312 +/- ##
===============================================
+ Coverage 64.00% 64.12% +0.12%
===============================================
Files 259 259
Lines 13075 13078 +3
===============================================
+ Hits 8368 8386 +18
+ Misses 4707 4692 -15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to ensure permissions are working correctly
For fossasia/open-event-frontend#5212