fix: Admin Sales API #7322
Merged
fix: Admin Sales API #7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 5, 2020
app/api/admin_sales/utils.py
Outdated
| """ | ||
| Groups orders by status and returns the total sales and ticket count as a | ||
| dictionary | ||
| """ | ||
| sales = Order.query.filter_by(event_id=event.id, status=status).with_entities(func.sum(Order.amount)).scalar() or 0 | ||
| tickets = get_count(TicketHolder.query.join(Order).filter(Order.event_id == event.id, Order.status == status)) |
There was a problem hiding this comment.
line too long (114 > 90 characters)
app/api/admin_sales/utils.py
Outdated
| """ | ||
| Groups orders by status and returns the total sales and ticket count as a | ||
| dictionary | ||
| """ | ||
| sales = Order.query.filter_by(event_id=event.id, status=status).with_entities(func.sum(Order.amount)).scalar() or 0 |
There was a problem hiding this comment.
Black would make changes.
line too long (119 > 90 characters)
houndci-bot
reviewed
Oct 5, 2020
| return { | ||
| 'sales_total': sum(o.amount for o in orders if o.status == status), | ||
| 'ticket_count': sum(o.tickets_count for o in orders if o.status == status), | ||
| 'sales_total': sales, |
Codecov Report
@@ Coverage Diff @@
## development #7322 +/- ##
============================================
Coverage 64.12% 64.13%
============================================
Files 259 259
Lines 13086 13095 +9
============================================
+ Hits 8392 8399 +7
- Misses 4694 4696 +2
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging cf65c09 into 3d562fa - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fossasia/open-event-frontend#5163