Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct session link and add site_link property #7356

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 14, 2020

@auto-label auto-label bot added the fix label Oct 14, 2020


def test_session_site_link(db):
session = SessionSubFactory(event__identifier='abcde', id=34567)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #7356 into development will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7356      +/-   ##
===============================================
+ Coverage        64.08%   64.12%   +0.04%     
===============================================
  Files              259      259              
  Lines            13114    13111       -3     
===============================================
+ Hits              8404     8408       +4     
+ Misses            4710     4703       -7     
Impacted Files Coverage Δ
app/api/helpers/mail.py 38.01% <ø> (+0.61%) ⬆️
app/api/sessions.py 58.78% <0.00%> (+1.22%) ⬆️
app/models/event.py 78.73% <100.00%> (+0.39%) ⬆️
app/models/session.py 95.16% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1225a93...862a7c1. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 8bbdd07 into fossasia:development Oct 14, 2020
@iamareebjamal iamareebjamal deleted the session-link branch October 14, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Proposal Mail: Wrong session link
2 participants