feat: Add Video Stream API #7360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 15, 2020
| class VideoStream(db.Model): | ||
| "Video Stream or Room" | ||
|
|
||
| __tablename__ = 'video_streams' |
| def query(self, view_kwargs): | ||
| query_ = self.session.query(VideoStream) | ||
|
|
||
| if view_kwargs.get('room_id'): |
|
|
||
| class VideoStreamSchema(Schema): | ||
| class Meta: | ||
| type_ = 'video-stream' |
Codecov Report
@@ Coverage Diff @@
## development #7360 +/- ##
===============================================
+ Coverage 64.23% 64.50% +0.27%
===============================================
Files 259 262 +3
Lines 13130 13233 +103
===============================================
+ Hits 8434 8536 +102
- Misses 4696 4697 +1
Continue to review full report at Codecov.
|
iamareebjamal
force-pushed
the
video-stream
branch
from
98aa8dd to
40c4b1a
Compare
houndci-bot
reviewed
Oct 19, 2020
|
|
||
| class MicrolocationSubVideoStreamFactory(MicrolocationFactoryBase): | ||
| event = factory.SubFactory(EventFactoryBasic) | ||
| video_stream = factory.SubFactory(VideoStreamFactoryBase) |
There was a problem hiding this comment.
redefinition of unused 'video_stream' from line 3
tests/factories/microlocation.py
Outdated
| @@ -1,9 +1,11 @@ | |||
| import factory | |||
|
|
|||
| from app.models import video_stream | |||
There was a problem hiding this comment.
'app.models.video_stream' imported but unused
| room = MicrolocationSubVideoStreamFactory(video_stream=stream) | ||
| session = SessionSubFactory(microlocation=room, event=room.event) | ||
| if user: | ||
| role, _ = get_or_create(Role, name='owner', title_name='Owner') |
| # decorators = (api.has_permission('is_admin', methods="POST"),) | ||
|
|
||
| def before_post(self, args, kwargs, data): | ||
| require_relationship(['rooms'], data) |
iamareebjamal
force-pushed
the
video-stream
branch
from
40c4b1a to
4885c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fossasia/open-event-frontend#4886