Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only speaker or organizer can access pending sessions #7364

Merged
merged 1 commit into from
Oct 17, 2020
Merged

fix: Only speaker or organizer can access pending sessions #7364

merged 1 commit into from
Oct 17, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 17, 2020 •
edited
Loading

@auto-label auto-label bot added the fix label Oct 17, 2020
houndci-bot
houndci-bot reviewed Oct 17, 2020
View reviewed changes
tests/all/integration/api/session/test_session_access_api.py
owner = new_user
creator = user
session = SessionSubFactory(creator_id=creator.id, **kwargs)
role, _ = get_or_create(Role, name='owner', title_name='Owner')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@iamareebjamal iamareebjamal mentioned this pull request Oct 17, 2020
Closed
5 tasks
@codecov
Copy link

codecov bot commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #7364 into development will increase coverage by 0.05%.
The diff coverage is 69.56%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #7364      +/-   ##
===============================================
+ Coverage        64.12%   64.18%   +0.05%     
===============================================
  Files              259      259              
  Lines            13111    13126      +15     
===============================================
+ Hits              8408     8425      +17     
+ Misses            4703     4701       -2
Impacted Files Coverage Δ
app/api/sessions.py 59.64% <46.15%> (+0.86%) ⬆️
app/api/helpers/permission_manager.py 61.14% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee0436...e36deb3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 8e28812 into fossasia:development Oct 17, 2020
@iamareebjamal iamareebjamal deleted the session-404 branch October 17, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending Session Pages Publicly Accessible
2 participants
@iamareebjamal @houndci-bot