fix: organizer can add speaker without email #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #7376 +/- ##
============================================
Coverage 64.23% 64.23%
============================================
Files 259 259
Lines 13130 13130
============================================
Hits 8434 8434
Misses 4696 4696
Continue to review full report at Codecov.
|
app/api/speakers.py
Outdated
| # and has_access('is_organizer', event_id=data['event']) | ||
| # and not data.get('email') | ||
| # ): | ||
| # data['email'] = current_user.email |
There was a problem hiding this comment.
We still need to assign the email if the user is organizer and is_email_overridden = False
maze-runnar
changed the title
iamareebjamal
approved these changes
Oct 25, 2020
|
@maze-runnar One condition is still left. If a non-organizer user sets email to null, it should be denied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related : fossasia/open-event-frontend#5359
Checklist
developmentbranch.